• Potatos_are_not_friends@lemmy.world
      link
      fedilink
      arrow-up
      19
      ·
      3 years ago

      This is pretty common with outside contractors.

      We just come in, say we’ll pay them x dollars and they give us code that passes the test. But that code will not at all align with any prior patterns.

      I absolutely know I’m guilty of it when I do freelancing. Sorry.

    • BaskinRobbins@sh.itjust.works
      link
      fedilink
      arrow-up
      13
      ·
      3 years ago

      You can always tell when someone’s been a career contractor because they never adhere to any of the established patterns/styles in the codebase.

      • gribodyr@lemmy.ml
        link
        fedilink
        arrow-up
        2
        ·
        3 years ago

        I disagree. Good career contractors should learn to write in the code style of the project. And the real pros do.

    • Troy@lemmy.ca
      link
      fedilink
      arrow-up
      7
      ·
      3 years ago

      That’s not to say that python coding habits are the best either – certainly they’re terrible when translating outside of python (most of the time). And even within python, someone who is used to with only the base modules will write it differently than writing PyQt and still completely different than someone doing numpy code… because the styles of coding of the underlying system change your coding mode. Like, my variables are all CamelCase when doing user interfaces with Qt because it makes sense there, stylistically.